In string search, replace unsafe_wrap with codeunits #48275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `findfirst(::String, ::String)` will eventually end up calling `unsafe_wrap` on both arguments, in order to use Julia's generic vector search functions. This causes unnecessary allocations. This PR replaces use of `unsafe_wrap` with `codeunits`, removing the allocation. See also: JuliaLang#45393
KristofferC
approved these changes
Jan 14, 2023
stevengj
approved these changes
Jan 14, 2023
|
CI errors seem unrelated. (On x86_64-win64-mingw32 it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
findfirst(::String, ::String)will eventually end up callingunsafe_wrapon both arguments, in order to use Julia's generic vector search functions. This causes unnecessary allocations.This PR replaces use of
unsafe_wrapwithcodeunits, removing the allocation.See also: #45393